When is a pull request too big?

November 17, 2021

Smaller pull requests are faster to write and easier to review. But how do you know when your pull request is getting “too big”?

There’s no hard and fast rule, but here are a few “yellow flags” for your consideration. If you start to see your PR crossing one of these thresholds, ask if you can push what you’ve done, and save the rest for another PR.

  • Does the PR have more than 50-100 lines of changes?
  • Does the PR touch more than 5-10 files?
  • Does the PR contain more than 5-10 commits?
  • Does the PR contain changes written more than 8 hours apart?

Related Content

The one code review method to rule them all

Find the method that works for you, and don't let anyone guilt you into thinking your way is "wrong".

Responding to “No code reviews by default”

Every team is different, but one thing is the same: all want to build the best product in the shortest time. There are different ways to achieve this.

Break glass in case of emergency

Should you block "bad" behaviors, or allow them in case of emergency? Why not both?