4 tips to jump the PR review queue
March 17, 2021
Are you tired of waiting for your colleagues to review your pull requests? Here are some quick tips to help your PRs filter to the top of the proverbial review queue.
- Short and sweet — Nobody likes reviewing long PRs. It might not be fair, but ten 10-line pull requests will generally get reviewed faster than a single 100-line pull request.
- Limit scope — One of the surest ways to confuse someone reading your change set is to mix concerns. Keep each PR focused on a single thing. One feature addition, one bug fix, or one refactor per PR!
- A good title — Give your PR a meaningful and accurate title. “Bugfix” doesn’t cut it. If someone has to divine the reason for your PR from the code, it’s a bad PR, and cognitive load (and thus wait times) go up!
- A good description — Link to any relevant issues, stories, or other related changes in the description. If there’s anything at all unclear about your changes, explain it. Don’t make your reviewer guess, or leave a comment asking for basic information.
The mechanics of test-driven development
Red-Green-Refactor may describe the mechanics of TDD, but not its essence.
What's the relationship between TDD and Evolutionary Design?
TDD doesn't give you ED for free, it only makes it easier.
TDD is slower the same way a drop cloth makes you slower
Painting without a drop cloth may be faster, but the hours of clean up outweigh savings.